Automatic rename of filenames with bash script

Question

[Morta]

Hi i want to rename all files with a 1 in a directory where the script is

#!/bin/bash
for filename in *.fasta; do 
     [ -f "$filename" ] || continue
     mv "$filename" "${filename//1/}"
done

But when I'm in /tmp and the execute filename.sh the filenames have still a 1 innit

Why?

[Pierre Lindenbaum]

run this version; show us the output:

#!/bin/bash
set -x
for filename in *.fasta; do
     ls -lah "${filename}"
     [ -f "${filename}" ] || continue
     mv -v "${filename}" "${filename//1/}"
done

[Morta]

[root@lapt0p tmp]# bash filename.sh

 for filename in *.fasta
 ls -lah '*.fasta'
 ls: Zugriff auf '*.fasta' nicht möglich: Datei oder Verzeichnis nicht gefunden
 '[' -f '*.fasta' ']'
 continue

Seems not to know the command fasta. How to fix it?

I can install a AUR package named fasta?! Is this command not part of the basic commands from bash?

[cpad0112]

1. Do not use root account for normal operations
2. Aur is a package repository for arch linux.

What is your distro?

[Morta]

1. Ok. I know is risky!
2. Yes

I replaced .fasta with .txt now it's editing all files with ending *.txt. I wasn't clear that the coder of this script want only modify fasta files.

How I do it if i want modifiy all files in a folder? A . instead of .txt or a simple ``?

[cpad0112]

How I do it if i want modifiy all files in a folder? A . instead of .txt or a simple ``?

instead of for filename in *.fasta, you can use for i in * or for i in $(ls *). You can also use find.

[Pierre Lindenbaum]

I wrote

ls -lah "${filename}"

not

ls -lah '${filename}'

[Morta]

I posted only the output of the script.

I copied one to one your new script.

[cpad0112]

what are you trying to do? You do not need a loop here. Use rename.

[Morta]

I did with rename but I was curious about how I do with this bashscript. I try to understand the error of the script for what I want to do.

[cpad0112]

can you try this?

#!/bin/bash
for filename in *.fasta; do 
     [ -f "$filename" ] || continue
     mv "$filename" "${filename/1/}"
done

But this would remove all '1's in file names.

Answer 1

[Pierre Lindenbaum]

ah yes sorry, that was the output , not my script. OK the message in german is clear. There is no file with the suffix *.fasta in the directory.

[Morta]

Ok. Thanks is now working with txt files with the word .txt instead of .fasta!

Answer 2

[fracarb8]

You can use rename. Depending on the version installed one of the commands below should do:

rename "1" "" *.fasta
rename "s/1//" *.fasta

The structure of the command is rename 's/search/replace/'