You should always use
use strict; at the beginning of your perl scripts. The benefit of this is that errors get flagged and your program won't run unless you get things right. You can read up on this here.
Using 'strict' means, that you will have to define each variable using the work
my to ensure that each variable name is unique. You will see examples of this in the edited code.
Open a file
The next thing I've noticed in your script is the way you open your file. Generally speaking, you should always include the mode you're using, i.e "<" for reading a file and ">" for writing to a file. Also, include the
die command in case Perl cannot read/write the file.
"<", "test data") or die;
Reading in your file
Once you've successfully opened your file, reading in your lines is rather simple. You would use a
while loop to do so.
push (@annovalue, $_);
I've used the
$_ variable, which is called the default value.
The while loop
Looking at your main code in the
while loop, your program will not match anything as the variable
$annovalue is not defined. Using
use strict; and
my will tell you that in the future. If you want to loop through every entry of an array, you will have to use a
open (my $OUTFILE, ">", "testData_out.txt");
if ($_ ne "")
my $feat_object ($seq_obj->get_SeqFeatures)
(($feat_object->primary_tag eq "CDS")
&& ($feat_object -> has_tag("protein_id")))
for my $val ($feat_object->get_tag_values("protein_id"))
if ($val=~ /$annovalue/)
$feat_object -> $set_tag_values("notes");
$seq_obj = $seqio_obj -> $next_seq();
print OUTFILE (
I advise you to be constant with your style. You used
my in your code sometimes, but it did not really have a purpose. I'm not entirely sure what's happening in your main body either, as it seems very confusing with all the
foreach structures. Furthermore, you should be constant with your curly brackets. Either you open your block of statements with a curly bracket on the same line as the statement or structure or you start on the next line. Regardless of which you prefer, stick with it!
If you have two
if statements referring to the same variable and following each other, you can use the
&& (and) operator to do so. There are more and you should look into this. They can be very handy and they make your code look tidier, more readable and you save a couple of lines.
Lastly, you print your results to a file which you haven't declared. The
OUTFILE has not been opened and you need to do this, otherwise Perl will not know where to write to and discard your results.
open (my $OUTFILE, ">", "test data_out.txt") or die;
I hope my comments help.